fix(msi): set the REBOOT property in the MSI
authorJyrki Gadinger <nilsding@nilsding.org>
Wed, 4 Jun 2025 08:20:15 +0000 (10:20 +0200)
committerbackportbot[bot] <backportbot[bot]@users.noreply.github.com>
Wed, 4 Jun 2025 09:06:18 +0000 (09:06 +0000)
A value of `ReallySuppress` will not display a reboot prompt whenever
the `ForceReboot` action was run, or whenever a reboot was scheduled
(e.g. by `FilesInUse`).  Apparently this will not reboot the machine on
its own either.

`winget` sets this property in its manifest[0], and according to reports in
issue #5369 this seems to work.

See also: https://learn.microsoft.com/en-us/windows/win32/msi/reboot

[0]: https://github.com/microsoft/winget-pkgs/blob/0b40904d1480f67d48c6d8e2ac7f27b31aa566c7/manifests/n/Nextcloud/NextcloudDesktop/3.16.5/Nextcloud.NextcloudDesktop.installer.yaml#L16

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
admin/win/msi/Nextcloud.wxs

index 942275ad8b5fd157a3a4db77f7f3ebbfe547f4db..fcc70de59c759a7419864584c9c4d87a2dae5b2e 100644 (file)
@@ -47,6 +47,7 @@
     <MajorUpgrade Schedule="afterInstallExecute" AllowDowngrades="yes" />
     <Property Id="REINSTALLMODE" Value="dmus" />
     <Property Id="MSIRMSHUTDOWN" Value="1" />
+    <Property Id="REBOOT" Value="ReallySuppress" />
 
     <Media Id="1" Cabinet="$(var.AppShortName).cab" EmbedCab="yes" />